Kill TreeMap, TreeSet, TrieMap, TrieSet, LruCache and EnumSet #19955
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gankra
changed the title
|
This looks great, thanks @gankro! |
|
@gankro r=me after rebase/squash |
Gankra
force-pushed
the
kill-all-code
branch
2 times, most recently
from
9e9768a to
7cb02a7
Compare
Gankra
force-pushed
the
kill-all-code
branch
from
7cb02a7 to
67d3823
Compare
bors
added a commit
that referenced
this pull request
Dec 19, 2014
EnumSet lives on in libcollections so that librustc can still use it. This adds a direct dependency on libcollections to librustc and libserialize. Should not be merged until rust-lang/rfcs#509 is accepted. All of these collections have already been moved to collect-rs where they will ideally be maintained and experimented with, or will be replaced by something better: https://github.com/Gankro/collect-rs/ [breaking-change] r? @aturon @alexcrichton
|
@gankro You write "Kill |
|
@tbu- It's not in std anymore; only libcollections. |
|
Hmm I think this PR accidentally destroyed the special rust/src/test/run-pass/issue-16278.rs Lines 15 to 17 in 74ae05a This breaks the regression testing that we would want for #16278 (I only happened to notice their absence because I was wondering why this file was listed here:) rust/src/test/run-pass/.gitattributes Line 2 in f17c230 |
kennytm
added a commit
to kennytm/rust
that referenced
this pull request
Sep 12, 2018
…278, r=wesleywiser Recover proper regression test for issue rust-lang#16278. Spawned from my note rust-lang#19955 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EnumSet lives on in libcollections so that librustc can still use it. This adds a direct dependency on libcollections to librustc and libserialize.
Should not be merged until rust-lang/rfcs#509 is accepted.
All of these collections have already been moved to collect-rs where they will ideally be maintained and experimented with, or will be replaced by something better: https://github.com/Gankro/collect-rs/[breaking-change]
r? @aturon @alexcrichton